Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #10

Open
aik099 opened this issue Feb 22, 2024 · 1 comment
Open

Improve test coverage #10

aik099 opened this issue Feb 22, 2024 · 1 comment

Comments

@aik099
Copy link
Member

aik099 commented Feb 22, 2024

Browsing through the driver code I've noticed, that most of the error reporting isn't covered by tests. Without this, we can't be sure if the code actually works.

Either the https://github.com/minkphp/driver-testsuite needs to be improved or this repo custom tests.

@stof
Copy link
Member

stof commented Feb 22, 2024

I think this might be a mix of both.

The error handling for start and stop should be covered in custom tests (as the failure modes there are specific to each driver).
The error handling of getWebdriver should as well because the DriverInterface makes it an undefined behavior to call methods on a non-started driver. It does not require getting a DriverException in such case.

Other cases might correspond to holes in the coverage of invalid usages in the shared testsuite (for instance, we added testing for some invalid form field value types among the latest improvements of that testsuite). Those should be implemented in the shared testsuite to improve coverage in all drivers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants