From a7ed361a824d90a1d8a5c76c0b1a579e2d938bad Mon Sep 17 00:00:00 2001 From: Maria Ines Parnisari Date: Thu, 19 Oct 2023 18:03:50 -0700 Subject: [PATCH] save to artifact, not cache --- .github/workflows/main.yaml | 8 ++++---- .github/workflows/prs.yaml | 8 +++----- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index de30994..c0f733e 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -40,8 +40,8 @@ jobs: github-token: ${{ secrets.GITHUB_TOKEN }} comment-on-alert: true - - name: Save benchmark data - uses: actions/cache/save@704facf57e6136b1bc63b828d79edcd491f0ee84 # v3.3.2 + - name: Save benchmark data without cache + - uses: actions/upload-artifact@v3 with: - path: ./cache/benchmark-data.json - key: ${{ runner.os }}-go-benchmark \ No newline at end of file + name: benchmark-main + path: ./cache/benchmark-data.json \ No newline at end of file diff --git a/.github/workflows/prs.yaml b/.github/workflows/prs.yaml index 9dfe254..4006fbc 100644 --- a/.github/workflows/prs.yaml +++ b/.github/workflows/prs.yaml @@ -23,13 +23,11 @@ jobs: set -o pipefail make bench | tee ${{ github.sha }}_bench_output.txt - # Download previous benchmark result from cache + # Download previous benchmark result - name: Download previous benchmark data - uses: actions/cache/restore@704facf57e6136b1bc63b828d79edcd491f0ee84 # v3.3.2 + - uses: actions/download-artifact@v3 with: - fail-on-cache-miss: true - path: ./cache/benchmark-data.json - key: ${{ runner.os }}-go-benchmark + name: benchmark-main - name: Compare benchmark result uses: benchmark-action/github-action-benchmark@70405016b032d44f409e4b1b451c40215cbe2393 # v1.18.0