-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize webassets #553
base: master
Are you sure you want to change the base?
Modernize webassets #553
Conversation
- autoprefixer needs a different attribute; webkit supports animation - handle babel's weird-ass preset error messages
272e408
to
b57e36d
Compare
Here's a CI run with the current tox config: https://github.com/offbyone/webassets/actions/runs/11026671771 I believe that readthedocs will still build this as-is, but I'm not 100% sure; it'd be nice to set up PR-based builds for RTD if you haven't and we can see if those work. |
This can be superseded by miracle2k/webassets#553 and a corresponding permanent update to pelican-plugin-webassets
Hey Chris. What do you think about my proposal in #555? |
Maybe I'm misunderstanding the relationship between the two, but I believe that this library is a dependency of the Pelican plugin; in order to get that plugin to work, this update needed to happen. I'd be up for a "courteous fork" under a new name, or potentially to vendor this code into the Pelican plugin, but I'm not sure that it can be directly folded in. I think this code is where the meat of the That's why I'm using my own forks of them here |
If that is the case, my vote would be for vendoring the needed code into the aforementioned Pelican plugin repository. |
I'm fine with that. |
If you (or anyone else for that matter) would like to submit PRs to that effect, I’d be happy to merge them post-haste, as well as make sure you have the requisite commit bit for that repo if you don’t already 😊 |
Per discussion in miracle2k/webassets#553
find_executable
Related Issues