Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing Keras when loading dataset #29

Open
swapsha96 opened this issue May 7, 2019 · 1 comment
Open

Importing Keras when loading dataset #29

swapsha96 opened this issue May 7, 2019 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@swapsha96
Copy link
Collaborator

I just observed that when I am using any function from mirapy.data.load_dataset, the module always runs from keras.utils.np_utils import to_categorical which is only used in one function. So if a user just wants to load dataset and doesn't have keras installed, it will throw an error. This is a utility that needs to be replaced by either creating our own to_categorical function or find a better way.

Note: Once the assignee creates the PR, s/he needs to check if notebook on X-ray binaries is working correctly.

@swapsha96 swapsha96 added the good first issue Good for newcomers label May 7, 2019
@akhilsinghal1234 akhilsinghal1234 added the bug Something isn't working label May 8, 2019
@swapsha96
Copy link
Collaborator Author

I will suggest using OneHotEncoder in sklearn to convert into categorical values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants