Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple atomizer component dependencies #158

Open
3 tasks done
jallen-frb opened this issue Aug 15, 2022 · 1 comment
Open
3 tasks done

Decouple atomizer component dependencies #158

jallen-frb opened this issue Aug 15, 2022 · 1 comment
Assignees
Labels
fix/bug Fixes errant behavior

Comments

@jallen-frb
Copy link
Collaborator

Affected Branch

trunk

Basic Diagnostics

  • I've pulled the latest changes on the affected branch and the issue is still present.

  • The issue is reproducible in docker

Description

In order to reproduce the issue, follow these steps:

  1. Run docker compose --file docker-compose-atomizer.yml up
  2. The watchtower comes online slowly which chains failures to connect to it and containers exit.

A quick fix is to add restart:always to each service in docker-compose-atomizer.yml, but @metalicjames mentioned that we should not rely on restarting containers/services. Each service should poll to see if the others are online without exiting.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jallen-frb jallen-frb added the fix/bug Fixes errant behavior label Aug 15, 2022
@mszulcz-mitre
Copy link
Contributor

Pull Request #157 seems relevant. I'm not familiar with the expected output from Step 1 in the bug description, but when I do Step 1 with the commit in #157, the output eventually stops with the sentinel being "Done":
image

Without the commit, the output continues for a long time (maybe forever) as the watchtower repeatedly attempts to connect:
image

Maybe we should consider adding the changes in #157 for the atomizer controller to the controllers of the other components so that they try multiple times to connect without failing. Here's the changes to the atomizer controller:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix/bug Fixes errant behavior
Projects
None yet
Development

No branches or pull requests

3 participants