Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8 tests fail when running tests locally on MacOS #291

Open
2 of 3 tasks
eolesinski opened this issue Jul 24, 2024 · 1 comment
Open
2 of 3 tasks

8 tests fail when running tests locally on MacOS #291

eolesinski opened this issue Jul 24, 2024 · 1 comment
Assignees
Labels
enhancement/testing Increases test coverage or quality fix/bug Fixes errant behavior

Comments

@eolesinski
Copy link
Contributor

eolesinski commented Jul 24, 2024

Affected Branch

Affected Branch: trunk

When running ./scripts/test.sh locally on macOS Sonoma 14.5, M3 Max 8 tests fail.

Specifically, when the test script completes, this is the result:

[----------] Global test environment tear-down
[==========] 257 tests from 37 test suites ran. (35554 ms total)
[  PASSED  ] 249 tests.
[  FAILED  ] 8 tests, listed below:
[  FAILED  ] tcp_rpc_test.echo_test
[  FAILED  ] tcp_rpc_test.response_error_test
[  FAILED  ] tcp_rpc_test.timeout_test
[  FAILED  ] tcp_rpc_test.no_callback_test
[  FAILED  ] tcp_rpc_test.cancel_test
[  FAILED  ] tcp_rpc_test.async_echo_test
[  FAILED  ] tcp_rpc_test.async_error_test
[  FAILED  ] sentinel_2pc_test.bad_rpc_server_endpoint

An isolated run of tcp_rpc_test.cancel_test returns:

Value of: server.listen(ep.first, ep.second)
  Actual: false
Expected: true

An isolated run of the last test sentinel_2pc_test.bad_rpc_server_endpoint returns:

Value of: ctl->init()
  Actual: true
Expected: false

An isolated run of the other six of the failing tests all return:

Value of: server.init()
  Actual: false
Expected: true

Basic Diagnostics

  • I've pulled the latest changes on the affected branch and the issue is still present.

  • The issue is reproducible in docker

Description

In order to reproduce the issue, follow these steps:

  1. Run ./scripts/test.sh

Code of Conduct

  • I agree to follow this project's Code of Conduct
@eolesinski eolesinski added the fix/bug Fixes errant behavior label Jul 24, 2024
@maurermi
Copy link
Collaborator

Was able to replicate this just now on the same hardware / OS. To get to this point in the test, one needs to make the changes specified in #290 (on a Mac)

@HalosGhost HalosGhost added the enhancement/testing Increases test coverage or quality label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement/testing Increases test coverage or quality fix/bug Fixes errant behavior
Projects
None yet
Development

No branches or pull requests

3 participants