guide_level() compatibility with ggplot2 >3.4.2
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
changed the title
guide_level() compatibility with ggplot2 >3.4.0guide_level() compatibility with ggplot2 >3.4.2
teunbrand
changed the title
guide_level() compatibility with ggplot2 >3.4.2guide_level() compatibility with ggplot2 >3.4.2
|
This should now be compatible with CRAN and development version of ggplot2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Mitchell,
Apologies for the cold PR without posting an issue first.
The ggplot2 package has changed the implementation of the guide system, which means that the old S3 system will no longer work, see ggplot2's news file. I'm aware that graphics functionality in distributional is scheduled to be deprecated, per here, but there are packages that reexport the guide functionality.
In any case, what this PR does is to create a hybrid of
guide_level()that should be compatible with the old system and the new system to ease transition. It is work in progress (WIP) for now, as I'm doing an inventory of how to preserve as many S3 guide extensions as is reasonable.Best,
Teun