Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper component to handle container sizes #888

Open
Tracked by #863
mfal opened this issue Oct 22, 2024 · 2 comments
Open
Tracked by #863

Wrapper component to handle container sizes #888

mfal opened this issue Oct 22, 2024 · 2 comments
Labels
question Further information is requested

Comments

@mfal
Copy link
Collaborator

mfal commented Oct 22, 2024

Container :: I'd love to see a container or wrapper component. When using a library like this, it'd be nice not to handle container sizes manually, espacialy since you have your own breakpoint definitions.

@mfal mfal added the question Further information is requested label Oct 22, 2024
@mfal
Copy link
Collaborator Author

mfal commented Oct 22, 2024

In the last weeks we have heavily used Flow and never missed such component. We use:

  • <ColumnLayout /> to get horizontal spacing
  • and <Section /> to get vertical spacing

@gskyarts can you explain your use case?

Maybe this issue is related to your question: #770

@mfal mfal changed the title Container :: I'd love to see a container or wrapper component. When using a library like this, it'd be nice not to handle container sizes manually, espacialy since you have your own breakpoint definitions. Wrapper component to handle container sizes Oct 22, 2024
@gskyarts
Copy link

Do you use Flow components directly in your context (container/wrapper) or standalone?

I would like to clarify my suggestion.
When using them standalone, without a <div style="max-width: 1200px"></div> wrapper, they render at full width. This can lead to oversized layouts on large screens like 49" display or 4K/8K monitors making them less user-friendly.

Here is a screen from 49" display to illustrate this.

Image

While i can create my own container handling, it would be smoother if this functionality was build directly into Flow and i can work individually with it. What are your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants