Handler is not updated

[zigzhang]

Hi,

Problem:
After starting serverless offline serverless offline start, I can publish a message on SNS offline without any problem, and the handler is running.
When I change the code in my handler and publish again a message, the previous handler is run, and not the updated one.

I need to stop serverless offline and re-start it for the changes to be taken into account.

Why it matters:
For debug purposes, it'd be great to be able to change the handler test without having to re-start serverless offline every time.

Version: node 8.10

    "serverless": "^1.26.1",
    "serverless-offline": "^3.20.3",
    "serverless-offline-sns": "^0.42.0",

Thanks!

[mj1618]

I'll look into this at some point, I can see it is inconvenient. Not sure how to solve it yet. It may be that we need this function to change to be called on every invocation rather than just once -
https://github.com/mj1618/serverless-offline-sns/blob/master/src/index.ts#L201

[frostyseb]

Hi, the function handler is still not updated to the latest. I am using the following versions:
Node: 16.20.0

"serverless": "^3.36.0",
"serverless-offline": "^13.2.0",
"serverless-offline-sns": "^0.77.2"

[dsarlo]

Thanks for the report @frostyseb. I will reopen this and will look into it at some point

[dsarlo]

@frostyseb A little update here. Did some testing and I came to the conclusion that 1) the handler needs to be re-imported on each invocation not just when we subscribe to the sns topic on initialization (as mentioned above) and 2) we need to be able to invalidate the node module cache.

Sadly, 2 is not currently possible which is why I initially removed cache invalidation as a parameter in version 0.77.0

See: nodejs/node#49442 - tracking esm cache busting

Once there is a solution available, I will resolve this issue. I have a branch ready to go. I was able to get this to work properly with a non-esm project using createRequire and deleting the module from the cache on each re-import but this does not work for esm projects, so for compatibility purposes, we will wait and see what the node team comes up with.

[frostyseb]

Hi @dsarlo , thank you very much for the update! I really appreciate your effort in this enhancement. Understandable on the esm cache busting issue and compatibility. We shall see how the node team will improve this.