-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cannot read properties of undefined - description #572
Comments
I've created a quick demo on Github pages: https://flatsiedatsie.github.io/web_llm_vision/ and then I created a Reddit post about your awesome work here: https://www.reddit.com/r/LocalLLaMA/comments/1fnjnkc/webllm_has_added_support_for_its_first_vision/ |
I haven't ran into this issue yet, but below are some info. The adapterInfo is defined here: The adapterInfo is populated here: Specifically, I am not very sure why |
I wonder if it is because your browser still prefers |
Sure, I'll give it a try. |
Thanks for all the info, I'll fix it today |
Though I believe using the latest chrome should fix it; but I'll make sure we are backward compatible |
The issue persists with the latest Thorium (126) but it looks like there have been further releases upstream.... Edit: there are no issues when using a nightly build of Chromium: 131.0.6742.0 |
Thanks for the info, fix is under the way |
This PR bumps TVMjs (i.e. `@mlc-ai/web-runtime`) from `0.18.0-dev0` to `0.18.0-dev1`. The only change is: - apache/tvm#17420 TVMjs `0.18.0-dev1` is compiled at apache/tvm@5e85443 with apache/tvm#17420 cherry-picked on top This should fix: - #572
0.2.70 should include the fix, please let me know whether it worked on your end, thank you! |
the fix does not appear to work on my end, but this may be an unrelated bug. The updated code is in the |
Hmm what is the bug you are seeing? |
Could it be that the CDN version doesn't always get updated properly? https://cdn.jsdelivr.net/npm/@mlc-ai/web-llm/+esm |
The CDN seems to take a bit to get updated. Perhaps you can try specify 0.2.70 specifically? https://www.jsdelivr.com/package/npm/@mlc-ai/web-llm |
Which version of brave are you on? I'll try to reproduce on my end |
Ahh I can reproduce on |
Turns out I missed an Apologies for the inconvenience! |
Glad you found a bug! I just realized I wasn't on the latest version of Brave:
I've upgraded now, and the problem is gone, even without being on 0.2.71. (and never any need to apologize, the fact that WebLLM even exists is awesome enough) |
Glad the issue is solved! Will close this one. Feel free to reopen / open new ones if issues persist |
I wonder if it is because you need to clear some cached files. I feel like the IIUC, the Perhaps do something like |
I removed |
I see! Glad it worked! |
I'm trying the Phi3.5 vision demo, but got the error below.
I proceeded to wrap that bit of code in
if(K.adapterInfo){ ... }
And then it started working.
Another thing I then ran into: I'm not allowed to use relative image paths?
The text was updated successfully, but these errors were encountered: