Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importance filter default is bad #155

Open
mb706 opened this issue May 22, 2023 · 3 comments
Open

importance filter default is bad #155

mb706 opened this issue May 22, 2023 · 3 comments

Comments

@mb706
Copy link
Contributor

mb706 commented May 22, 2023

the importance filter by default uses the "featureless" learner by default, which makes the filter basically useless. There are likely very few cases in which the user wants to initialize the importance filter with the featureless learner. Therefore, the learner should not have a default; when constructing the importance filter without providing a learner, an error should be thrown instead.

@sebffischer
Copy link
Member

I agree: #130

@sebffischer
Copy link
Member

sebffischer commented Jun 30, 2023

I think these choices were made to make the as.data.table() conversion work. Maybe we should implement your solution from mlr3pipelines in mlr3misc.

@sebffischer
Copy link
Member

mlr-org/mlr3misc#92 would help for the dict -> dt conversion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants