-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start antolini implementation #343
base: main
Are you sure you want to change the base?
Conversation
Hi @bblodfon this starts an Antolini implementation. I've used a new method for the Cindex just using R vectorisation. To demonstrate it I've shown how you can also use it with Harrell's C and it produces identical results (within 1e-6) at significantly faster time. The current Antolini implementation might be broken though as frequently seeing C<0.5, I suspect the bug is in lines 6-7 when calling the distr6 function, as you did this recently with several models/measures please could you take a look at that line? Once happy I'll code it into an actual measure |
with the updated code, the use of the What doesn't make sense to me is that scores coming from I did a small benchmark to check the output values:
|
Well not treated the same, the inequality is reversed https://github.com/mlr-org/mlr3proba/pull/343/files#diff-033f1cd099ed95e401392d6763a5b44330ec434215f754990b0c0215220a7538R32-R36 |
No description provided.