Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to tune threshold for binary classifiers? #209

Closed
cjm715 opened this issue Nov 21, 2019 · 7 comments
Closed

Is it possible to tune threshold for binary classifiers? #209

cjm715 opened this issue Nov 21, 2019 · 7 comments

Comments

@cjm715
Copy link

cjm715 commented Nov 21, 2019

.... or set the threshold to a fixed value in a tuning instance?

@berndbischl
Copy link
Member

this is currently not supported directly in mlr3tuning, but definitely in scope as a next feature
@mllg @mb706 what do we currently have in mlr3 here and in mlr3pipelines?

@mllg
Copy link
Member

mllg commented Nov 22, 2019

There is another issue about this somewhere. We need to arrange a call to decide what to do with other predict-time hyperparameters.

@mllg
Copy link
Member

mllg commented Nov 22, 2019

There is is now a prototype to tune a single prediction in the threshold branch.

@berndbischl
Copy link
Member

is it documented how to set thresholds simply with models? can you link it here for reference pls?
also my feeling is that threshold optimization should be a PipeOp in mlr3pipelines, so we must dicuss this with @mb706

@mb706
Copy link
Collaborator

mb706 commented Dec 17, 2019

This should be a PipeOp and would work relatively efficiently when we implement #212. There is a small problem here: This would not be as efficient as it could be if the Learner that produces the predictions has a slow predict() function. Ideally we would want some functionality that notices that only parameters of the PipeOp after the Learner have changed, and that evaluates the PipeOp$predict() multiple times, but the Learner$train() only once.

@pfistfl
Copy link
Member

pfistfl commented Mar 9, 2020

Started implementation in mlr-org/mlr3pipelines#356.

@sebffischer
Copy link
Member

this is implemented via po("tunethreshold")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants