Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove max heap size for Julia-style GC trigger #134

Open
qinsoon opened this issue Feb 22, 2024 · 0 comments
Open

Remove max heap size for Julia-style GC trigger #134

qinsoon opened this issue Feb 22, 2024 · 0 comments
Labels
bug Something isn't working v1.9.2+RAI Issues about the branch v1.9.2+RAI

Comments

@qinsoon
Copy link
Member

qinsoon commented Feb 22, 2024

/// Is current heap full?
fn is_heap_full(&self, plan: &dyn Plan<VM = JuliaVM>) -> bool {
plan.get_reserved_pages()
>= conversions::bytes_to_pages_up(self.max_total_memory.load(Ordering::Relaxed))
}

/// Return the upper bound of heap size
fn get_max_heap_size_in_pages(&self) -> usize {
conversions::bytes_to_pages_up(self.max_total_memory.load(Ordering::Relaxed))
}

These lines still uses max_total_memory as a hard limit for MMTk, while Julia treats max_total_memory as a soft limit. So we may still see MMTk OOM. We should simply use usize::MAX in those lines.

@qinsoon qinsoon added bug Something isn't working v1.9.2+RAI Issues about the branch v1.9.2+RAI labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.9.2+RAI Issues about the branch v1.9.2+RAI
Projects
None yet
Development

No branches or pull requests

1 participant