Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer document.hasFocus() to tracking focus/blur events #97

Open
mikol opened this issue Sep 13, 2022 · 0 comments · May be fixed by #98
Open

Prefer document.hasFocus() to tracking focus/blur events #97

mikol opened this issue Sep 13, 2022 · 0 comments · May be fixed by #98

Comments

@mikol
Copy link

mikol commented Sep 13, 2022

document.hasFocus() is supported across the board and will be more reliable/correct than tracking state based on focus/blur events. Additionally, it means that Notification component users won’t need to initialize an empty element (<Notification disableActiveWindow title=''/>) in order for the component to properly track window activity.
mikol added a commit to mikol/react-web-notification that referenced this issue Sep 14, 2022
@mikol
Prefer document.hasFocus() to tracking focus/blur events
a338d4f 
Fixes mobilusoss#97
@mikol mikol linked a pull request Sep 14, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prefer document.hasFocus() to tracking focus/blur events mikol/react-web-notification
1 participant
@mikol