Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the URL schemes #194

Open
samoht opened this issue Jul 20, 2016 · 0 comments
Open

Review the URL schemes #194

samoht opened this issue Jul 20, 2016 · 0 comments
Labels
area/github kind/enhancement

Comments

@samoht
Copy link
Member

samoht commented Jul 20, 2016

Currently, --datakit and --listen arguments of the GitHub bridge, as well as the -a address of the GH webhook listener. For instance we have:

  • tcp://localhost:5640 (--listen)
  • tcp:localhost:5640 (--datakit)
  • [localhost]:5640 (-a)

We should try to converge to something more consistent as it already caused me much confusion.

See #188
avsm pushed a commit to avsm/datakit that referenced this issue Jan 19, 2017
@hannesm
Merge pull request moby#194 from hannesm/no-profile
1c110bc 
remove mirage-profile from mirage-solo5 (sync with upstream)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/github kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samoht