-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for older gcc versions #85
Comments
I guess so. I'm afraid we'll have time to do that from September onwards. If you know how to handle Github's CI scripts, you may try this on a branch and then test the binary artefacts yourself, it if works we can merge it into master in 1 second. |
I think we use gcc 4.8.5 currently, and might upgrade to 8.x later this year, but I am not entirely sure. I tested with clang 7.x and it does produce binaries that are compatible with gcc 4.8. |
Hi - I have tried addressing this, but the combination of CMake 3.8 and GCC 4.8 is not very common and I have problems getting the docker images to compile the sources. GCC 8 works well by the way. |
- This closes #89 and possibly relates to #90. - The new manually triggered CI job uses the suggestions from #89 to find the minimum CMake version. - Wrong version of cmake required to compile the library #89 to find the minimum CMake version. - The minor adjustments in the CMakeLists.txt reduce the needed CMake version to 3.8 instead of 3.18 - The missing CoolProp include directories have also been fixed. - As pointed out in #85, we may want to bring back the subdirectory notation for GCC and friends, this is also included here.
Modelica Language Specification about Resources/Library directory and subdirectories:
https://specification.modelica.org/master/functions.html#annotations-for-external-libraries-and-include-files
modelica/ModelicaSpecification#1316
Sub-directories per platform:
Sub-sub-directories per compiler and version:
It seems sub-sub-directories per gcc version are supported by Dymola 2020 and newer, I am somewhat unsure about other tools.
Would it be possible to pre-compile for multiple gcc versions (one new like gcc81, one old, like gcc48) and put them in the corresponding directories?
If gcc 4.8.5 is too old to compile CoolProp, clang can be used, it produces binaries compatible with gcc 4.8.5
The text was updated successfully, but these errors were encountered: