Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update cabonapi to v0.17.0 #1112

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Conversation

Tetrergeru
Copy link
Member

@Tetrergeru Tetrergeru commented Oct 8, 2024

Попытка обновить карбонапи прошла неуспешно, обнаружен баг с вайлдкардами, изменения ревёртнули. Этот ПР возвращает обновлённую версию карбона и исправляет баг с вайлдкардами

}

for _, metricData := range metricsData {
md := newMetricDataFromGraphite(metricData, len(result.Metrics) == 0)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Единственное изменение в логике вычисления метрик. Добавил тесты в database_test.go

@Tetrergeru Tetrergeru marked this pull request as ready for review October 9, 2024 07:58
@Tetrergeru Tetrergeru requested a review from a team as a code owner October 9, 2024 07:58
@Tetrergeru
Copy link
Member Author

/build

@kissken
Copy link
Member

kissken commented Oct 10, 2024

@Tetrergeru напиши, плз описание к ПР

@Tetrergeru Tetrergeru merged commit 993d37f into master Oct 10, 2024
6 checks passed
@Tetrergeru Tetrergeru deleted the feature/update-carbonapi-to-0.17.0 branch October 10, 2024 10:04
Copy link

Build and push Docker images with tag: 2024-10-10.993d37f

1 similar comment
Copy link

Build and push Docker images with tag: 2024-10-10.993d37f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants