Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mode resolveCiFriendliesOnly don't resolve variables in <dependency> and <dependenceManagement> in submodules. #422

Open
lowcasz opened this issue Jul 10, 2024 · 1 comment

Comments

@lowcasz
Copy link

lowcasz commented Jul 10, 2024

Plugin with mode resolveCiFriendliesOnly works in parent pom correctly, but in submodules it replace variables in parent and version tags, other occurences are ignored.

<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <modelVersion>4.0.0</modelVersion>
  <parent>
    <groupId>maven-flatten-plugin.bug</groupId>
    <artifactId>parent</artifactId>
    <version>HERE-WORKS</version>
  </parent>
  <artifactId>demo</artifactId>
  <version>HERE-WORKS</version>
  <packaging>pom</packaging>
  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>maven-flatten-plugin.bug</groupId>
        <artifactId>dependency-management</artifactId>
        <version>${revision}</version><!------------------------------------- this place is not resolved -->
        <type>pom</type>
        <scope>import</scope>
      </dependency>
    </dependencies>
  </dependencyManagement>
  <dependencies>
    <dependency>
      <groupId>maven-flatten-plugin.bug</groupId>
      <artifactId>dependency</artifactId>
      <version>${revision}</version><!-------------------------------------- this place is not resolved -->
      <type>pom</type>
      <scope>import</scope>
    </dependency>
  </dependencies>
</project>

The bug demo and sample workaround is available here: https://github.com/lowcasz/maven-flatten-plugin-bug

@lowcasz
Copy link
Author

lowcasz commented Jul 10, 2024

Connected to: #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant