Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go examples should have caught NewClient issue #401

Open
bruuuuuuuce opened this issue Mar 20, 2024 · 1 comment
Open

Go examples should have caught NewClient issue #401

bruuuuuuuce opened this issue Mar 20, 2024 · 1 comment
Labels
bug 🐞 Something isn't working

Comments

@bruuuuuuuce
Copy link
Contributor

bruuuuuuuce commented Mar 20, 2024

When trying to upgrade grpc-go to include our changes to add the NewClient method, we accidentally broke the go sdk. The issue stems from how we used the replace directive to point to our forked version of grpc-go.

replace google.golang.org/grpc => github.com/momentohq/grpc-go v1.61.0-dev.0.20240306220430-6ad501388d03

When a customer would install our sdk, they would see an error saying NewClient method does not exist. This should have been caught by our examples

github.com/momentohq/client-sdk-go v1.19.0

Which we pointing to a version of the sdk that included this replace change, but the examples passed. We should figure out why they were passing, and fix it so they are able to validate our sdk installs correctly. The change was released in version 1.17.0

image

@bruuuuuuuce bruuuuuuuce added the bug 🐞 Something isn't working label Mar 20, 2024
@cprice404
Copy link
Collaborator

we can't do this due to how go packaging works; we could instead add a CI script that checks for replace in the go.mod and fails CI.

@cprice404 cprice404 removed the next up label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants