From d8a5bd613dde2d55fc72ec0e5c6c481533baf396 Mon Sep 17 00:00:00 2001 From: Christian Zunker Date: Fri, 17 Nov 2023 06:20:47 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=B9=20Prevent=20nil=20panic=20when=20r?= =?UTF-8?q?ecording=20is=20not=20set?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In case recording isn't specififed during scanner initialisation, set the NullRecording Signed-off-by: Christian Zunker --- policy/scan/local_scanner.go | 4 ++++ policy/scan/local_scanner_test.go | 9 +++++++++ 2 files changed, 13 insertions(+) diff --git a/policy/scan/local_scanner.go b/policy/scan/local_scanner.go index 96feb64d..5ff85b48 100644 --- a/policy/scan/local_scanner.go +++ b/policy/scan/local_scanner.go @@ -102,6 +102,10 @@ func NewLocalScanner(opts ...ScannerOption) *LocalScanner { opts[i](ls) } + if ls.recording == nil { + ls.recording = providers.NullRecording{} + } + return ls } diff --git a/policy/scan/local_scanner_test.go b/policy/scan/local_scanner_test.go index 95421c9f..59de365f 100644 --- a/policy/scan/local_scanner_test.go +++ b/policy/scan/local_scanner_test.go @@ -100,3 +100,12 @@ func TestCreateAssetList(t *testing.T) { require.Equal(t, "mondoo-operator-123", candidates[2].asset.ManagedBy) }) } + +func TestDefaultConfig(t *testing.T) { + t.Run("without opts", func(t *testing.T) { + scanner := NewLocalScanner() + require.NotNil(t, scanner) + + require.Equal(t, providers.NullRecording{}, scanner.recording) + }) +}