Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when using input.mode = 'clock' sense start/stop #455

Open
trentgill opened this issue Nov 18, 2021 · 0 comments
Open

when using input.mode = 'clock' sense start/stop #455

trentgill opened this issue Nov 18, 2021 · 0 comments
Labels
enhancement New feature or request feature new features yet to be added
Milestone

Comments

@trentgill
Copy link
Collaborator

at present we just do our best to try and follow the input clock. if the clock disappears we let the clock continue running at whatever rate it was set before the clock disappeared.

in contrast, it would seem more useful to detect when a clock is deactivated & stop the internal clock (and trigger clock.stop() event). then restart & trigger clock.start() on the first newly received trigger.

in the stop case, we likely need to wait for 3~4 clock misses to be confident the clock has stopped, vs just a change in tempo.

for startup, we must be sure to activate immediately on the first pulse, and assume the tempo is the same as it was before a stop.

@trentgill trentgill added enhancement New feature or request feature new features yet to be added labels Nov 18, 2021
@trentgill trentgill modified the milestone: 3.1? 3.5? 4.0? Feb 3, 2023
@trentgill trentgill added this to the v4.1 milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature new features yet to be added
Projects
None yet
Development

No branches or pull requests

1 participant