Lattice Transport Bug (norns 2.7.3)

[BeatRossmy]

I repost a bug report regarding the lattice transport value
@ryleelyman

What i observed was that the transport received in the actions of individual sprockets did not match with the defined ppqn and were offset by 2.

When reading through the source code (norns/lattice.lua at main · monome/norns · GitHub 1). I discovered that there is probably a bug in function Lattice:pulse(). The incrementation of transport is done within the loop which handles the ordering of sprockets, which leads to a transport value dependent on the defined sprocket order and is multiplied by 5.

The issue is in line 124.

norns/lua/lib/lattice.lua

Lines 93 to 127 in e8ae360

	function Lattice:pulse()
	if self.enabled then
	local ppc = self.ppqn * 4 -- pulses per cycle; "4" because in music a "quarter note" == "1/4"
	local flagged=false
	for i = 1, 5 do
	for _, id in ipairs(self.sprocket_ordering[i]) do
	local sprocket = self.sprockets[id]
	if sprocket.enabled then
	sprocket.phase = sprocket.phase + 1
	local swing_val = 2 * sprocket.swing / 100
	if not sprocket.downbeat then
	swing_val = 1
	end
	if sprocket.phase > sprocket.division * ppc * swing_val then
	sprocket.phase = sprocket.phase - (sprocket.division * ppc)
	if sprocket.delay_new ~= nil then
	sprocket.phase = sprocket.phase - (sprocket.division * ppc) * (1 - (sprocket.delay - sprocket.delay_new))
	sprocket.delay = sprocket.delay_new
	sprocket.delay_new = nil
	end
	sprocket.action(self.transport)
	sprocket.downbeat = not sprocket.downbeat
	end
	elseif sprocket.flag then
	self.sprockets[sprocket.id] = nil
	flagged = true
	end
	end
	if flagged then
	self:order_sprockets()
	end
	self.transport = self.transport + 1
	end
	end
	end

[robbielyman]

I believe a fix for this was merged in #1638.