Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination required #22

Open
majidh8 opened this issue Sep 12, 2019 · 3 comments
Open

Pagination required #22

majidh8 opened this issue Sep 12, 2019 · 3 comments

Comments

@majidh8
Copy link

majidh8 commented Sep 12, 2019

Hello, this plugin is very handy. The only problem we have with it is that it loads very slowly when there are lots of rules as in our case. We have nearly 500 rules (https://MYMOODLEURL.com/local/profilecohort/index.php) and the page takes a good minute to load all of the data. Can you add pagination as a setting so admins can choose to display let's say 50 rules per page?

@carcavic
Copy link

Hello. I have the same problem: I created around 480 rules for more than 200 cohorts and now I can't show the page content.
Your plugin is very helpul, thank you.
Carlo

@carcavic
Copy link

Hello to all.
Unfortunately I have a huge problem with the plugin, because now I can't access to the page where to create and modify rules.
The problem is for sure caused by the high number of cohorts and rules but I need to use more this great plugin, so I have two option to propose:

  1. can someone help me to modify the php info settings or other settings in order to allows the browser to show the page? keep in mind that I have already modified the max_execution_time to 90 sec.
  2. if someone is available to work on the pagination function, i can pay for it.
    Please let me know something.
    Thank you so much in advance.
    Carlo

@abias
Copy link
Member

abias commented Oct 24, 2019

Hi all,

thanks for getting in touch about this issue.

I can report back from our point of view:

  • This plugin was never designed to hold a huge number of rules. At our university, we are using it with approx. 30 rules and it works fine for us. "Works for me" is no excuse for problems, but at least an explanation.
  • If your huge number of rules is because you are filling cohorts for each lecture term, for each class or something like that, you might want to look at https://github.com/catalyst/moodle-local_cohortauto instead.
  • Adding pagination is currently out of scope for us. Not only because the plugin works for the number of rules which it was designed for, but especially because we would have to rebuild the JavaScript reordering mechanism which relies on the fact that all rules are on the same page.
  • I would be interested anyway to learn about the bottleneck in your scenario. If you are able to run the Tideways PHP profiler in your setup (see https://docs.moodle.org/dev/Profiling_PHP and https://docs.moodle.org/dev/Setting_up_xhprof_on_Moodle), please post the critical path which is consuming the computing time here. Perhaps we can fix that without adding any pagination.

@carcavic - If you were already able to raise max_execution_time to 90, you might want to raise it even more. At our installation, we have set this setting to more than 10 minutes and have been running this setup for a decade without any problems.

@carcavic - Regarding paying for fixing this issue: This plugin was built by a Moodle partner of ours. If you would be willing to pay for fixing the bottleneck and and for adding pagination, please see my profile https://github.com/abias and turn to me privately.

I will leave this issue open for now for future reference.

Cheers,
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants