Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing active class in menu items made with Boost's custommenuitems #384

Closed
haw-fachadmin opened this issue Sep 7, 2023 · 4 comments · May be fixed by #706
Closed

Fixing missing active class in menu items made with Boost's custommenuitems #384

haw-fachadmin opened this issue Sep 7, 2023 · 4 comments · May be fixed by #706
Labels
bug Something isn't working

Comments

@haw-fachadmin
Copy link

haw-fachadmin commented Sep 7, 2023

In Boost theme, there's an annoying issue: the links of menu items made with Boost's custommenuitems field in theme settings don't get an active class assigned to them.
Notice: This matters if you have multiple custom horizontal menu items instead of putting them into a dropdown.

Would be great to get that fixed in Boost Union!

@wiebkemueller-hsh wiebkemueller-hsh added the discussion needed Soemthing which need to be discussed before writing the first line of code label Sep 27, 2023
@wiebkemueller-hsh
Copy link
Collaborator

Hello HAW-Fachadmin,

thank you for posting this. I believe there is also the necessity to discuss this regarding the smart menu feature inlcuded in Boost Union. Menu items created with the smart menu also do not get an active class, but this might be for a reason.

E.g. I can create a external link, in this case an active link is of no use.
E.g. I can create a menu with submenus that are only displayed after clicking on the top categorie of the menu.

I marked this "discussion needed".

Regards from H
Wiebke

@wiebkemueller-hsh wiebkemueller-hsh added the improvement Improvement of any existing (UX, design, code, performance,...) but not a new feature and not a bug. label Oct 5, 2023
@wiebkemueller-hsh
Copy link
Collaborator

assigned to yvonne for requirements check

@wiebkemueller-hsh wiebkemueller-hsh added bug Something isn't working and removed discussion needed Soemthing which need to be discussed before writing the first line of code labels Feb 29, 2024
@whuml
Copy link
Collaborator

whuml commented Mar 26, 2024

Identified Issue as Boost Union / Smart Menue Bug:
moodles custommenuitems "activ" (underline) works fine, as long, as "Boost Union Smartmenue" is not activated.
Activating or unhiding (show) "Smart Menus" causes that active custommenuitems are not underlined anymore.
Smartmenueitems are not underlined as activ as well/ in gerneral.
Instead "home" is underlined as active :-(

@wiebkemueller-hsh
Copy link
Collaborator

Hello @haw-fachadmin,

we'll close this ticket. The behaviour you described seems to be fixed in Boost (just verifyed on the official mount orange school testsystem). There are other issues related to the missing highlighting of the smart menu items that are being discussed in #715
#620 .

Regards on behalf of the BU-team!
Wiebke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: CLOSED
4 participants