Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: Changing the activity icon purpose of LTI activities #690

Open
abias opened this issue Jul 13, 2024 · 1 comment
Open

Cleanup: Changing the activity icon purpose of LTI activities #690

abias opened this issue Jul 13, 2024 · 1 comment
Labels
affecting 4.3 only affects Moodle 4.3 affecting 4.4 only affects Moodle 4.4 cleanup Something which has to be cleaned up or improved in the inner workings of the plugin

Comments

@abias
Copy link
Member

abias commented Jul 13, 2024

Since Moodle 4.3, the manual creation of LTI instances when adding an LTI activity is not possible anymore. This means that, unless the admin added an LTI instance globally, the LTI activity is not available at all in the activity chooser. On the other hand, changing the activity icon purpose for globally registered LTI instances does not really make sense as you can add an aligned icon to the LTI instance directly.

Against this background, the "External tool" setting within the "Activity icon purposes" feature is useless and should be removed.
@abias abias added improvement Improvement of any existing (UX, design, code, performance,...) but not a new feature and not a bug. affecting 4.3 only affects Moodle 4.3 affecting 4.4 only affects Moodle 4.4 cleanup Something which has to be cleaned up or improved in the inner workings of the plugin and removed improvement Improvement of any existing (UX, design, code, performance,...) but not a new feature and not a bug. labels Jul 13, 2024
@abias abias changed the title Improvement: Changing the activity icon purpose of LTI activities Cleanup: Changing the activity icon purpose of LTI activities Jul 13, 2024
@Menrath
Copy link
Contributor

Menrath commented Sep 17, 2024 •
edited
Loading

Is this related? https://tracker.moodle.org/browse/MDL-80914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affecting 4.3 only affects Moodle 4.3 affecting 4.4 only affects Moodle 4.4 cleanup Something which has to be cleaned up or improved in the inner workings of the plugin
Projects
Boost Union Planning Board
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abias @Menrath