Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the existence of a Dockerfile on target revision. #107

Open
tf0054 opened this issue Dec 23, 2014 · 3 comments
Open

Check the existence of a Dockerfile on target revision. #107

tf0054 opened this issue Dec 23, 2014 · 3 comments
Labels

Comments

@tf0054
Copy link

tf0054 commented Dec 23, 2014

If the pool cannot find the appropriate container, the pool will forward our browser to the building screen and start the building without checking the existence of a Dockerfile on the target repo top.

@tf0054
Copy link
Author

tf0054 commented Dec 23, 2014

And maybe it makes inside dockers' ip address inconsistency problem.

@ainoya
Copy link
Collaborator

ainoya commented Dec 23, 2014

Thanks for reporting the issue 🙏
I figured out this problem as seeing the errors when cloning repository without Dockerfile in pool system.
Errors below;

I, [2014-12-22T15:31:55.064284 #56]  INFO -- : FATA[0000] no Dockerfile found in /app/images/workspace/77e94cf6b46ed196e1e1de1ca6d8f01b9cd03d3f 


I, [2014-12-22T15:31:55.064818 #56]  INFO -- : image_id is /app/images/workspace/77e94cf6b46ed196e1e1de1ca6d8f01b9cd03d3f

I, [2014-12-22T15:31:55.084880 #56]  INFO -- : Write image id <> and commit id <77e94cf6b46ed196e1e1de1ca6d8f01b9cd03d3f> to /app/images/ids

To fix the bug, we should implement the exception handling about build error.
Ref. exception handling is implemented here.

@ainoya ainoya added the bug label Dec 23, 2014
@ainoya
Copy link
Collaborator

ainoya commented Dec 23, 2014

After supporting #53, docker-api ruby client may returns various exceptions, then we'll be able to care this problem more easily with the exception handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants