Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http does not redirect to https #110

Open
garmeeh opened this issue Jan 14, 2022 · 3 comments
Open

http does not redirect to https #110

garmeeh opened this issue Jan 14, 2022 · 3 comments

Comments

@garmeeh
Copy link

garmeeh commented Jan 14, 2022

Describe the bug
Hey, I just came across your site earlier. I clicked a link from twitter where someone tweeted and mentioned pay.party this resulted in me landing on http://pay.party and getting the Not Secure warning.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'http://pay.party'
  2. Notice it does not redirect to secure site

Expected behavior
It redirects to secure site

@wkarshat
Copy link

An issue with the site, not the app.
Tip.Party appears to handle http redirect correctly, but where's its site repo?

@hmrtn
Copy link
Member

hmrtn commented Jan 18, 2022

https://pay.party and https://app.pay.party / https://dev.pay.party does have the correct certificates. This is an issue with the landing page redirects. Looking into it.

@nyedidikeke
Copy link

An issue with the site, not the app. Tip.Party appears to handle http redirect correctly, but where's its site repo?

https://pay.party and https://app.pay.party / https://dev.pay.party does have the correct certificates. This is an issue with the landing page redirects. Looking into it.

@wkarshat @hmux The challenge is not with "the site" nor "the app". Neither it is about correctness of TLS certificates; it is about unencrypted data in transit, thereby making users more susceptible to attacks.
I wouldn’t have the site available over HTTP and HTTPS, and redirect HTTP to HTTPS - it would work; Yes, but strongly discouraged.

An attacker resolved to launch a MITM attack on users could persuade them to visit your site over plain HTTP. The attacker may fake your site and acquire sensitive data from your users, or proxy to the legitimate HTTPS version of your site and snoop all data, if traffic could be diverted (e.g. DNS poisoning).

Why not serve just one version of the site (HTTPS only), simply redirect incoming HTTP traffic to HTTPS, then enable HSTS to aid in the prevention of the scenario above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants