Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate the hash transition logic. #263

Open
jayeshbairagi opened this issue Feb 12, 2020 · 0 comments
Open

Deduplicate the hash transition logic. #263

jayeshbairagi opened this issue Feb 12, 2020 · 0 comments

Comments

@jayeshbairagi
Copy link
Collaborator

  • TRANSITION_TYPEHASH and function hashTransition are coded in multiple contracts i.e Core, SelfProtocore.
  • Create a new contract that implements the hashing logic and let the other contracts inherit it.
  • Similarly, in the unit tests, it has multiple implementations in test/coconsensus and test/self_protocore. Deduplicate the logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jayeshbairagi