Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of getRemoteGatewayLatestProvenBlockNumber #304

Closed
wants to merge 8 commits into from
Closed

Implementation of getRemoteGatewayLatestProvenBlockNumber #304

wants to merge 8 commits into from

Conversation

abhayks1
Copy link
Collaborator

@abhayks1 abhayks1 commented Mar 6, 2020

  • Implementation of getRemoteGatewayLatestProvenBlockNumber in ERC20Gateway, ERC20Cogateway, ConsensusGateway and ConsensusCogateway.

Fixes #303

@0xsarvesh
Copy link
Collaborator

@abhayks1 can you please add some tests to validate if it works. Thanks

@abhayks1 abhayks1 self-assigned this Mar 11, 2020
@abhayks1
Copy link
Collaborator Author

@abhayks1 can you please add some tests to validate if it works. Thanks

@sarvesh-ost assertions added.

@abhayks1 abhayks1 removed their assignment Mar 11, 2020
benjaminbollen
benjaminbollen requested changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@benjaminbollen benjaminbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you not implement it once in Proof.sol?

@abhayks1
Copy link
Collaborator Author

Closing this PR as ticket description has changed. Will put comment in the ticket.

@abhayks1 abhayks1 closed this Mar 22, 2020
@abhayks1 abhayks1 mentioned this pull request Mar 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminbollen benjaminbollen benjaminbollen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gateways should expose view function to get remoteGatewayLastProvenBlockNumber
3 participants
@abhayks1 @0xsarvesh @benjaminbollen