Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus events #7

Open
shiraShapira opened this issue Jun 7, 2020 · 3 comments
Open

consensus events #7

shiraShapira opened this issue Jun 7, 2020 · 3 comments

Comments

@shiraShapira
Copy link

"round event" doesn't have "consensus" field, if we want to know consensus state we can check which events are contained in round.receivedEvents in the "assign round" func.

@arrivets
Copy link
Contributor

arrivets commented Jun 7, 2020

Hey,
Sorry but I don't understand what the issue is about.
Is this a question about the consensus algorithm?

@shiraShapira
Copy link
Author

maybe I have a mistake but for my opinion, we cant know if event reaches consensus by field:roundEvent.Consensus because in babble round event contains just "witness,famous".I suggested new way to check if event is contained in consensus events.
image

@arrivets
Copy link
Contributor

arrivets commented Jun 7, 2020

Thanks.
Yes you are right.
That line can be deleted, and replace with a check in ReceivedEvents.
Feel free to create a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants