Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POA duplicate nominees #26

Open
arrivets opened this issue Nov 18, 2019 · 3 comments
Open

POA duplicate nominees #26

arrivets opened this issue Nov 18, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@arrivets
Copy link
Contributor

It is possible to nominate the same address twice, which messes things up.
The same is probably true of evictees as well.

@jonknight73
Copy link
Contributor

Recompiling the master contract with solc version 0.5.11 I cannot reproduce thus behaviour. The generated bytecode.go file does have differences in the generated bytecode. I will investigate further, but if the contract can be shown to be working with a more current compiler version, I would be minded to set the pragma in solidity to the working version or higher.

@arrivets
Copy link
Contributor Author

Creating duplicate nominees is no longer possible but there is another problem.

A whitelist member cannot vote for the same nominee in different ballots.

Ex:
Alice is a nominee
Bob votes for her ( yes or no, doesn't matter)
Alice's application is rejected ( someone voted no ) - she gets ejected from the nominee list
Alice gets nominated again
Bob tries to vote for her again ----> BREAKS

@jonknight73
Copy link
Contributor

Fixed in 4cd2afd in develop. Will be promoted to master in the release later today.

@jonknight73 jonknight73 added the bug Something isn't working label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants