Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_ntree_per_split is 0 #18

Open
meditations opened this issue Jan 2, 2020 · 1 comment
Open

max_ntree_per_split is 0 #18

meditations opened this issue Jan 2, 2020 · 1 comment

Comments

@meditations
Copy link

It seems the max_ntree_per_split is not properly initiated, and it's always 0.

Traceback (most recent call last):
File "main.py", line 102, in
main()
File "main.py", line 94, in main
train_DEEPGBM(args, num_data, cate_data, plot_title, key="")
File "/Users/binrong/Desktop/Code/DeepGBM/experiments/train_models.py", line 165, in train_DEEPGBM
emb_model = EmbeddingModel(n_models, max_ntree_per_split, args.embsize, args.maxleaf+1, n_output, group_average, task=args.task).to(device)
File "/Users/binrong/Desktop/Code/DeepGBM/experiments/models/components.py", line 230, in init
stdv = math.sqrt(1.0 /(max_ntree_per_split))
ZeroDivisionError: float division by zero

@motefly
Copy link
Owner

motefly commented Jan 2, 2020

Thanks, there may be some corner cases that make it an error, please consider fixing it in your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants