Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would be nice, if you can add a github actions example #29

Open
Ismoh opened this issue Feb 1, 2022 · 8 comments
Open

Would be nice, if you can add a github actions example #29

Ismoh opened this issue Feb 1, 2022 · 8 comments

Comments

@Ismoh
Copy link

Ismoh commented Feb 1, 2022

I was struggling with github actions, until I found this after days:

#21 (comment)

Would be nice to add this in your readme, for all the ppl struggling with this!

Have a look on this:
#21 (comment)

@alerque
Copy link
Contributor

alerque commented Feb 3, 2022

Why was this closed? It seems reasonable to add example usage on Actions to the README to match the current Travis example.

@Ismoh Ismoh reopened this Feb 3, 2022
@Ismoh
Copy link
Author

Ismoh commented Feb 3, 2022

Yea, you're right. I closed it, because there is a reference issue, where you can find additional infos, but while double checking this issue, I recognised the initial problem I had, isn't mentioned.

So:
Would be nice to add the github actions setup in readme.md

@Ismoh
Copy link
Author

Ismoh commented Feb 3, 2022

@moteus I could fork this repo and create a pull request, if you like.

@Ismoh
Copy link
Author

Ismoh commented Apr 23, 2022

Is this repo dying?

@alerque
Copy link
Contributor

alerque commented Apr 23, 2022

No the repo isn't dying. The maintainer is not very active, but when things need fixing or contributions come in they do eventually get dealt with. In the mean time the project works fine in its current form.

If you want a current example of this in use maybe checkout the busted testing workflow for my fluent-lua project and it's coverage output here. Note that this workflow successfully aggregates coverage results across all the test runs on different Lua versions.

@Ismoh
Copy link
Author

Ismoh commented Apr 23, 2022

I dont get this running on Windows. Do you know an example of github action using windows?

@alerque
Copy link
Contributor

alerque commented Apr 23, 2022

No, I don't use Windows at all in real life are rarely in testing. I'm not familiar with the issues running Lua based stuff on it. I suggest if you think something is wrong with the project you open a specific issue related to whatever Windows problem you are seeing. This issue asking for a documentation example is fair enough but understandably low priority for a volunteer maintainer. Given that I've shown a working GitHub Actions example in use, solving this documentation thing won't solve your issue anyway. Leave this here for the docs to be addressed eventually, but post specific details of your Windows problem if necessary.

@Ismoh
Copy link
Author

Ismoh commented Apr 23, 2022

Yea, sure thing! Thank you for the answers, have a nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants