Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Ctrl-C doesn't work if just requiring proper-lockfile #111

Open
aslushnikov opened this issue Dec 20, 2022 · 0 comments · May be fixed by #112
Open

bug: Ctrl-C doesn't work if just requiring proper-lockfile #111

aslushnikov opened this issue Dec 20, 2022 · 0 comments · May be fixed by #112

Comments

@aslushnikov
Copy link

Consider the following snippet:

const properLockfile = require('proper-lockfile'); // 1

for (let i = 0; i < 1_000_000; i += 1)
  console.log(i);

It take a few seconds to run the snippet. Unfortunately, hitting Ctrl-C to abort execution does not work.
However, when removing the (1) line with proper-lockfile require, Ctrl-C would work as expected.

This has been reported to us downstream at Playwright: microsoft/playwright#19418
aslushnikov added a commit to aslushnikov/node-proper-lockfile that referenced this issue Dec 20, 2022
@aslushnikov
fix: do not subscribe to process signal handlers unless necessary
0ae637e 
Fixes moxystudio#111
@aslushnikov aslushnikov linked a pull request Dec 20, 2022 that will close this issue
Open
@aslushnikov aslushnikov mentioned this issue Jan 9, 2023
Merged
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Jan 9, 2023
@aslushnikov
chore: vendor proper-lockfile dependency
fe49e95 
This patch vendors the https://github.com/moxystudio/node-proper-lockfile
project we rely to manage Playwright Registry.

The reason to vender is the following upstream issue that
didn't get resolved in almost a month: moxystudio/node-proper-lockfile#111

Follow-up will apply the fix for the issue to the vendored file.

NOTE: this patch also inlines all code in a single file.

References microsoft#19418
aslushnikov added a commit to aslushnikov/playwright that referenced this issue Jan 10, 2023
@aslushnikov
chore: vendor proper-lockfile dependency
16fc2aa 
This patch vendors the https://github.com/moxystudio/node-proper-lockfile
project we rely to manage Playwright Registry.

The reason to vender is the following upstream issue that
didn't get resolved in almost a month: moxystudio/node-proper-lockfile#111

Follow-up will apply the fix for the issue to the vendored file.

NOTE: this patch also inlines all code in a single file.

References microsoft#19418
aslushnikov added a commit to microsoft/playwright that referenced this issue Jan 10, 2023
@aslushnikov
chore: vendor proper-lockfile dependency (#19969)
8f62aa9 
This patch vendors the
https://github.com/moxystudio/node-proper-lockfile
project we rely to manage Playwright Registry.

The reason to vender is the following upstream issue that
didn't get resolved in almost a month:
moxystudio/node-proper-lockfile#111

Follow-up will apply the fix for the issue to the vendored file.

NOTE: this patch also inlines all code in a single file.

References #19418
@keegancsmith keegancsmith mentioned this issue Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not subscribe to process signal handlers unless necessary aslushnikov/node-proper-lockfile
1 participant
@aslushnikov