ReferenceError: reference to undefined property "error"

[pdehaan]

Running the latest code from master (1ec24a3) in Nightly and spotted this error in my console:

ReferenceError: reference to undefined property "error"
— via master-password-setup.js:74

https://github.com/mozilla-lockbox/lockbox-extension/blob/9f732e7161d011ac5111a75ed45b563e7fa5f23f/src/webextension/firstrun/components/master-password-setup.js#L74

[devinreams]

@pdehaan To help narrow down when this was introduced, can you recall a point-in-time this wasn't happening? We could then use git-bisect to find the culprit.

Unless this immediately rings any bells for @jimporter or @linuxwolf.

[jimporter]

Is this causing an actual problem, or is it just random error spew? We get lots of reference errors that I think are the result of babel doing various browser polyfills for the fancy syntax we use.

[pdehaan]

I don't recall when this was introduced. Not sure if I've been trolling through the dev console logs before now.
I also don't think it was breaking anything or causing any issues. But it was the only warning I spotted that wasn't coming from DevTools or babel/webpack.

Looks like it was introduced in c118f9e. I assume it only appears because there is no error prop in this.state when we destructure.

[devinreams]

@pdehaan I ran through a fresh profile and don't see any stray errors. Are you seeing this still?

Either way, #209 will remove/replace the "master password". I'm closing this as stale and soon-to-be superseded but please feel free to re-open if you spot something we missed.