Skip to content
This repository has been archived by the owner on Feb 7, 2019. It is now read-only.

Tweak doorhanger to say "master password" #321

Closed
pdehaan opened this issue Nov 10, 2017 · 6 comments
Closed

Tweak doorhanger to say "master password" #321

pdehaan opened this issue Nov 10, 2017 · 6 comments
Milestone

Comments

@pdehaan
Copy link
Contributor

pdehaan commented Nov 10, 2017

Per #295 (comment),

Possibly unrelated to everything, but I notice in the screenshot above it says "Enter your password" in the doorhanger. Shouldn't that say "Enter your master password" to be consistent with the firstrun experience?

vs:

Easy fix, I'll PR shortly.

@devinreams
Copy link
Contributor

Easy fix, I'll PR shortly.

You stumbled onto something here, @pdehaan. I believe there is a pending content/copy decision on what to actually call it (hint: maybe not master password as it may not remain for much longer). @sandysage can shed light on that..

@pdehaan
Copy link
Contributor Author

pdehaan commented Nov 10, 2017

PR #322

@sandysage
Copy link
Contributor

@pdehaan This is a good catch. But any effort put forth here wouldn't be retained in near(ish) updates. We go into great detail in #209 around the changes to how users secure (lock) their Lockbox. One implication of this change is the account email and password becomes the digital key (master password). So the current implementation of "master password" goes away.

@m8ttyB
Copy link
Contributor

m8ttyB commented Nov 10, 2017

What's the time frame for the FxA flows landing?

@devinreams
Copy link
Contributor

What's the time frame for the FxA flows landing?

ASAP. You'll note the tracking issue @sandysage referenced above was ambitiously moved into the next milestone (0.1.3) as it's a must-have for Beta. 😁

@m8ttyB
Copy link
Contributor

m8ttyB commented Nov 10, 2017

Let's bump this to WONTFIX .. @pdehaan keep those uber nits coming. They are appreciated.

@m8ttyB m8ttyB closed this as completed Nov 10, 2017
@m8ttyB m8ttyB added this to the 0.1.2 milestone Nov 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants