Skip to content
This repository has been archived by the owner on Feb 7, 2019. It is now read-only.

Photon updates, 3rd pass #392

Closed
18 tasks done
devinreams opened this issue Dec 7, 2017 · 3 comments
Closed
18 tasks done

Photon updates, 3rd pass #392

devinreams opened this issue Dec 7, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@devinreams
Copy link
Contributor

devinreams commented Dec 7, 2017

Continuing the work started at #331 and #351

Zeplin: https://app.zeplin.io/project/59fb4868c5e7608593f76965

Todo


  • "Disabled"/inactivate/muted state of the sidebar list items when an item is selected (greys out all entries but the one selected)
  • Disabled "Home" button when not on a item detail (create, edit, view) view (aka can't click "Home" when home)
  • Disable "Save Entry" until at least one field has been populated

  • <ItemDetails/> (and <EditItemDetails/>) are designed as (theoretically) reusable components that could be put anywhere. Somewhere in <CurrentSelection/> would be a better place
    • Content area bg for the selected item should match either of these two values depending

  • doorhanger search padding to have more space
  • "manage lockbox" button shorter, background color? (instead of ghost button, make it a puffy?)
  • entry details: move "title" to title bar (out of detail view) and shorter
  • extend background of item details all the way to bottom of screen (content area is gray, white space beneath)
  • red alert button style for delete (keep primary for discard)
  • Search bar magnify icon and clear icon (when populated) based on screenshot below: screen shot 2017-11-13 at 11 41 21 am
  • a little wider width for doorhanger?
  • sidebar: secondary (no username)" and "(no site name)" CSS treatment (lighter color)

  • Reordering the item fields (not sure if we need to do anything about this, though I do have a feeling we'll end up reverting this when we have multi-origin support)
  • Bold-face or not on the non-editable item fields (just something for @changecourse to think about; see above)
  • Miscellaneous small issues with the item list
@devinreams devinreams added this to the 0.1.4 milestone Dec 7, 2017
@devinreams devinreams self-assigned this Dec 7, 2017
This was referenced Dec 7, 2017
@devinreams
Copy link
Contributor Author

Discussed with @changecourse and @jimporter today. Ryan says the top three are very close to "must have" (prioritized list above ☝️)

Jim says the first item is probably do-able as a consistent "0 entry state" display with placeholder content we swap out at the last minute. 🤞

@devinreams
Copy link
Contributor Author

Added more leftover items from #351 above. This is our "post launch" discussion/todo/to-decide list and currently at the top of the backlog due to the fact a) some of the attempted work is in-complete and b) the accumulation of tech debt started in that branch.

@changecourse
Copy link
Contributor

Closing this issue, as we'll be breaking up new design needs on a 'per-component' basis rather than grouped in such a large manner moving forward, per a discussion with @sandysage

New issues (by component) forthcoming, and will include some of the tasks listed above in a more organized manner...

@ghost ghost removed the to do label Jan 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants