Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or replace heka_plugin_raven #151

Open
say-yawn opened this issue Apr 28, 2020 · 0 comments
Open

Remove or replace heka_plugin_raven #151

say-yawn opened this issue Apr 28, 2020 · 0 comments
Labels
code-cleanup refactor and clean the codebase

Comments

@say-yawn
Copy link
Contributor

say-yawn commented Apr 28, 2020

About this Issue

After accomplishing #150 and have moved from raven to sentry-sdk, some of the tests files uses the heck_plugin_raven which should be either be removed or replaced.

As @jwhitlock pointed out here

There are a few instances of raven in the shavar/tests folder, in config sections such as [heka_plugin_raven]. Those may need to be removed, or it could signal a new heka plugin is needed.

There's also a line in shaver.testing.ini, which is mentioned in README.md for local development, so that may be a place to figure it out.

@say-yawn say-yawn added the code-cleanup refactor and clean the codebase label Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-cleanup refactor and clean the codebase
Projects
None yet
Development

No branches or pull requests

1 participant