Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Manual approval of version should automatically clear delayed rejection on the version being approved #15097

Open
1 task done
abhn opened this issue Oct 17, 2024 · 0 comments

Comments

@abhn
Copy link

abhn commented Oct 17, 2024

What happened?

For add-on 869700 version 24.3.48.1 I see that

  • the reviewer sent a delayed rejection
  • then later, the reviewer manually approved the add-on
  • then later, the version got rejected as the delayed rejection timer ran out and it was never cleared.

What did you expect to happen?

I'm trying to think if this is an intended behaviour, but so far I feel like this shouldn't happen. If a reviewer approves a version pending rejection, they won't intend on still rejecting it at date that was set in the original review verdict.

If multiple versions are delayed rejected, the delayed rejection should only be dropped for the version manually approved.

Is there an existing issue for this?

  • I have searched the existing issues

┆Issue is synchronized with this Jira Task

@abhn abhn changed the title [Bug]: Manual add-on approval should automatically cancel delayed rejection [Bug]: Manual add-on approval should automatically clear delayed rejection on the version being approved Oct 17, 2024
@abhn abhn changed the title [Bug]: Manual add-on approval should automatically clear delayed rejection on the version being approved [Bug]: Manual approval of version should automatically clear delayed rejection on the version being approved Oct 17, 2024
@abhn abhn removed the needs:info label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant