Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test on Android #2028

Open
mxinden opened this issue Aug 1, 2024 · 3 comments · May be fixed by #2058
Open

ci: test on Android #2028

mxinden opened this issue Aug 1, 2024 · 3 comments · May be fixed by #2058

Comments

@mxinden
Copy link
Collaborator

mxinden commented Aug 1, 2024

quinn-rs/quinn#1950 adds a GitHub job, testing quinn on Android.

Neqo doesn't have much platform specific code other than:

neqo/neqo-crypto/build.rs

Lines 226 to 229 in c80630b

} else if env::consts::OS == "android" {
builder = builder.clang_arg("-DLINUX");
builder = builder.clang_arg("-DANDROID");
}

That said, Neqo's dependencies have platform dependent code and Android is a tier 1 Firefox build target.

Objections to adding the same CI job to Neqo?

@larseggert
Copy link
Collaborator

No objections. Is it much slower than our other CI tests?

@mxinden
Copy link
Collaborator Author

mxinden commented Aug 1, 2024

Running all quinn unit tests takes about 5 minutes, including dependency installation, build and emulator startup.

@larseggert
Copy link
Collaborator

Let's do a PR and see how long it takes.

Are there other targets we should be testing on?

@mxinden mxinden linked a pull request Aug 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants