Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming TG.Number to TG.Constant #30

Open
DGruenwald opened this issue Apr 2, 2015 · 6 comments
Open

Renaming TG.Number to TG.Constant #30

DGruenwald opened this issue Apr 2, 2015 · 6 comments

Comments

@DGruenwald
Copy link
Contributor

I think it would be better if TG.Number was renamed to TG.Constant.
In my opinion, it makes a bit more sense in the context of generating values and gives a better idea of what it does and what it is used for.

@mrdoob
Copy link
Owner

mrdoob commented Apr 12, 2015

Hmmm... Could you elaborate a bit more?

@DGruenwald
Copy link
Contributor Author

What I mean by "it makes a bit more sense in the context of generating values" is, if you think of these generators as mathematical functions like, for example, TG.SinX would be z(x, y) = sin(x), then TG.Number would be a so called constant function.

Or, another reason why I think it would make more sense is because the number 1, which is used here, is also a mathematical constant.

Mainly the reason why I was suggesting that it should be changed is because, in my opinion the name TG.Number is a bit ambiguous and TG.Constant would imply some properties that would help understand what it does (output a fixed value) and what it could be used for (offset the output value, for example).

@mrdoob
Copy link
Owner

mrdoob commented Feb 27, 2016

Actually, how about TG.Fill?

@DGruenwald
Copy link
Contributor Author

Yes, that sounds good!
If it's alright, I'm gonna do this with some other minor changes and a bit of clean up of some of my code that I've been wanting to do.

@mrdoob
Copy link
Owner

mrdoob commented Apr 21, 2017

Any luck? 😅

@DGruenwald
Copy link
Contributor Author

DGruenwald commented Apr 23, 2017

Oh! Sorry. I didn't realize that you were waiting for this.

It's been a while and I've been playing around with this every now and then, so there is some stuff that has piled up over time.

Anyways, I've prepared some of those changes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants