Implemented tqdm_total to Enable Crate User Setting a Pbar Length #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngth when initialising a Tqdm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20.
Unfortunately, Rust does not allow for overloading of functions via varying parameter lengths. I've added a function
tqdm_totalthat sets a user-given pbar length. As this opens to the door toInfo.totalbeing smaller than the number of iterations, I've adjusted the crate behavior to be similar to the python tqdm crate. Should the number of iterations be higher than foreseen by the user, the progress bar disappears.I also ran
cargo fmtacross the project and changedimpl ToStringintoimpl Displayto keep in line with best practices.