-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the print Athena function #236
Merged
SemyonSinchenko
merged 10 commits into
mrpowers-io:planning-1.0-release
from
nijanthanvijayakumar:feature/issue-199-remove-athena-func
Jul 11, 2024
Merged
Remove the print Athena function #236
SemyonSinchenko
merged 10 commits into
mrpowers-io:planning-1.0-release
from
nijanthanvijayakumar:feature/issue-199-remove-athena-func
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to mrpowers-io#173 Add maintainers to `pyproject.toml` file * Add a `maintainers` section below the `authors` section. * Include the names and contact information of the maintainers (first version only). * Use the format `name <email>` for each maintainer. * Add a comment above the `maintainers` section to indicate its purpose.
* Describe how to add ruff in IDEs like VSCode & PyCharm Following changes have been made in the file(s): * **CONTRIBUTING.md** - Remove mention of Black - Add instructions on how to add ruff to VSCode - Add instructions on how to add ruff to PyCharm
* According to one of the points in the issue mrpowers-io#199 by @MrPowers, this function should never have been created. * This particular commit removes this function and its references from the quinn repo.
Add maintainers to pyproject.toml & update CONTRIBUTING.md with ruff setup for IDEs (mrpowers-io#173 and mrpowers-io#163)
Related to mrpowers-io#234 Update git command in CONTRIBUTING.md file * Change `git remote --set-url` to `git remote set-url` for setting the URL for the origin. * Ensure the command is correct and does not produce an error.
…mand Fix git command in CONTRIBUTING.md
Fix git command in CONTRIBUTING.md
@MrPowers and @SemyonSinchenko - added another PR to address one of the points in the issue: #199 Please let me know your thoughts. |
SemyonSinchenko
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR is related to the #199 and does the following:
Types of changes
Further comments