Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the print Athena function #236

Conversation

nijanthanvijayakumar
Copy link
Contributor

Proposed changes

This PR is related to the #199 and does the following:

  • Remove the print_athena_create_table function
    • According to one of the points in the issue quinn 1.0 release planning #199 by @MrPowers, this function should never have been created.
    • This particular commit removes this function and its references from the quinn repo.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

  • Does not close the issue quinn 1.0 release planning #199 as there are other open items in that. However, addresses one of the points i.e.,

    get rid of functions that should have never been added (e.g. print_athena_create_table

nijanthanvijayakumar and others added 10 commits July 8, 2024 08:04
Related to mrpowers-io#173

Add maintainers to `pyproject.toml` file

* Add a `maintainers` section below the `authors` section.
* Include the names and contact information of the maintainers (first version only).
* Use the format `name <email>` for each maintainer.
* Add a comment above the `maintainers` section to indicate its purpose.
* Describe how to add ruff in IDEs like VSCode & PyCharm

Following changes have been made in the file(s):
* **CONTRIBUTING.md**
  - Remove mention of Black
  - Add instructions on how to add ruff to VSCode
  - Add instructions on how to add ruff to PyCharm
* According to one of the points in the issue mrpowers-io#199 by @MrPowers, this function should never have been created.
* This particular commit removes this function and its references from the quinn repo.
Add maintainers to pyproject.toml & update CONTRIBUTING.md with ruff setup for IDEs (mrpowers-io#173 and mrpowers-io#163)
Related to mrpowers-io#234

Update git command in CONTRIBUTING.md file

* Change `git remote --set-url` to `git remote set-url` for setting the URL for the origin.
* Ensure the command is correct and does not produce an error.
@nijanthanvijayakumar
Copy link
Contributor Author

nijanthanvijayakumar commented Jul 11, 2024

@MrPowers and @SemyonSinchenko - added another PR to address one of the points in the issue: #199

Please let me know your thoughts.

Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@SemyonSinchenko SemyonSinchenko merged commit f07755a into mrpowers-io:planning-1.0-release Jul 11, 2024
@nijanthanvijayakumar nijanthanvijayakumar deleted the feature/issue-199-remove-athena-func branch July 11, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants