Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assertColumnEquality doesn't work with floating point numbers #25

Open
MrPowers opened this issue Aug 16, 2018 · 2 comments
Open

assertColumnEquality doesn't work with floating point numbers #25

MrPowers opened this issue Aug 16, 2018 · 2 comments

Comments

@MrPowers
Copy link
Collaborator

No description provided.

@MrPowers
Copy link
Collaborator Author

@snithish - Have you used assertColumnEquality yet? It's way better than assertSmallDataFrameEquality usually...

Can you please help me get the assertDoubleTypeColumnEquality method to work properly: https://github.com/MrPowers/spark-fast-tests/blob/master/src/main/scala/com/github/mrpowers/spark/fast/tests/ColumnComparer.scala#L50-L65

This method is broken for two reasons:

  1. It doesn't throw an error when the numbers are different
  2. It doesn't work with null values

You're a Scala wizard, so I'm sure you'll be able to fix this no problem 😉

@snithish
Copy link
Contributor

@MrPowers I have not got a chance with use assertColumnEquality but seems to be interesting, I will try to fix it.

@snithish snithish mentioned this issue Aug 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MrPowers @snithish