Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get shareable link not working. #1

Open
zikrikhairan opened this issue Mar 21, 2019 · 5 comments
Open

Get shareable link not working. #1

zikrikhairan opened this issue Mar 21, 2019 · 5 comments

Comments

@zikrikhairan
Copy link

When I click get shareable link, its nothing happen.

@mshossain110
Copy link
Owner

Thank you for creating the first issue in my repository.

I have to say sorry that all feature is not complete yet, like the shareable link, move file, permission. Whenever I will get time I will complete those features.

I hope you will get in touch and keep giving feedback.
Thanks

@zikrikhairan
Copy link
Author

ok, no problem.

@antonis-ant
Copy link

Hello, I would like to contribute to the project and maybe help with the shareable link functionality. Would it be ok if I tried to resolve this issue ? If yes I sure could use some info about how it functions so far and whatnot. Thank you :)

@mshossain110
Copy link
Owner

Hello @tonyanant

you are welcome to contribute to my application. at this moment I have done 70% of shareable link feature. in a fresh pull, you will see the shareable link is generating in the modal. now I need a page where the shareable file will show in frontend. I have created the page just need the design and fetch data in the controller. if you are able to do, you are welcome.

@antonis-ant
Copy link

antonis-ant commented Sep 22, 2019

Great, thank you! I will ge to to it then. Just one last question though: How come you created a laravel view for the share link page and not a vue view since the rest of the application uses vue for the front end? Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants