Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

PCCA contains deprecated method #442

Open
Zsailer opened this issue Sep 24, 2014 · 0 comments
Open

PCCA contains deprecated method #442

Zsailer opened this issue Sep 24, 2014 · 0 comments

Comments

@Zsailer
Copy link

Zsailer commented Sep 24, 2014

In the PCCAPlus class from lumping.pcca_plus, the optimize_A method uses Scipy's optimize.anneal method. This is deprecated in SciPy v0.14.0 version, and it uses optimize.basinhopping instead. Scipy returns a couple warnings about this.

I have not yet investigated these methods enough to see how much of a difference this makes. I'd be happy to look into this more and submit a PR with the new method. I'm sure it's pretty trivial.

Thanks for all the great work here, too!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant