Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to pin Flask dependencies for the user venv or it's almost guaranteed to break in the future #2467

Open
carlosperate opened this issue Oct 23, 2023 · 0 comments

Comments

@carlosperate
Copy link
Member

carlosperate commented Oct 23, 2023

As partially done in this PR, which we only noticed because we were building Mu after Flask/Werkzeug v3 were released:
#2465

Flask (and other Pallets projects) don't pin/lock up versions, which is arguably a commonly accepted approach, but that means that all Flask users will need to do this to ensure future pip installs don't fail:

More than that, Pallets often pushes breaking changes in "minor" releases, as they don't follow semver:
https://blog.miguelgrinberg.com/post/some-more-to-talk-about-flask

So, it looks like we might have to do the pinning ourselves.

Of course, that means having the risk of current packages not being compatible with future OS/Python releases (for example, with different manylinux versions, or any binary packages that might specify cp3x compatibility instead of the generic abi3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant