Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

production build ignores additions in package.json #29

Open
nvdk opened this issue May 27, 2021 · 3 comments
Open

production build ignores additions in package.json #29

nvdk opened this issue May 27, 2021 · 3 comments

Comments

@nvdk
Copy link
Member

nvdk commented May 27, 2021

Currently the production build ignores any additions that are made in the app's package.json file. Dependencies are installed, but any addition to script or other configuration for packages that typically resides in package.json is not taken into account.

It could be argued this is by design and extra scripts and configuration should not be available when running in production mode, but it does feel like a limitation. Perhaps merging the package.json file of the app and a template is a more flexible approach?

@nvdk
Copy link
Member Author

nvdk commented May 27, 2021

The approach in #30 seems to work quite well, though it should probably be tested a bit more.

@erikap
Copy link
Member

erikap commented Aug 8, 2022

Is this still the case on v1.6.0?

@erikap erikap mentioned this issue Aug 8, 2022
@nvdk
Copy link
Member Author

nvdk commented Oct 12, 2023

this is still the case in 1.7.0, because we start the app from the package.json in mu-javascript-template the scripts are not found when running npm run xxx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants