Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comprehensive tests for classic phonetic #1

Open
mugli opened this issue Mar 7, 2021 · 2 comments
Open

Add comprehensive tests for classic phonetic #1

mugli opened this issue Mar 7, 2021 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@mugli
Copy link
Owner

mugli commented Mar 7, 2021

testdata.txt is just a placeholder now. Need to add comprehensive testcases to cover all the patterns and exceptions.

@mugli mugli added the help wanted Extra attention is needed label Mar 7, 2021
@milon
Copy link

milon commented Jul 20, 2022

One question bhai, why do you use a string for is completed value for the Trie Node instead of a boolean? Just curious.

@mugli
Copy link
Owner Author

mugli commented Jul 20, 2022

Storing the complete word to avoid traversing and rebuilding them every time we reach a complete node. It saves both time and unnecessary allocation (lot of string concatenation). And since the complete words are saved anyway in the right nodes, we don't need another marker for that, saves at least a byte for each word.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants